swarm: add ListenClose #1586
Merged
swarm: add ListenClose #1586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
requested changes
Jun 3, 2022
Stebalien
approved these changes
Jun 4, 2022
|
@marten-seemann LGTM, but I'll leave it up to you to merge. |
marten-seemann
approved these changes
Jun 5, 2022
MarcoPolo
pushed a commit
that referenced
this pull request
Jun 24, 2022
* feat(swarm): add ListenClose * fix(swarm): fix ListenClose behavior * refactor(swarm): move the listener's closing log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreating libp2p/go-libp2p-swarm#319.
Add the missing
ListenClosemethod, as it is impossible to close existing listeners.Useful in many situations, especially on systems that no longer handle listeners after the operating system has suspended them without closing them, when applications run in the background for example (iOS).
This offers the possibility to update the network listener without completely restarting the swarm.
I think this method should also be added to the network interface.
The decision is yours